Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sampling result name #1661

Merged
merged 8 commits into from
Sep 18, 2020

Conversation

euniceek
Copy link
Contributor

This PR updates the names of Sampling result for consistency, closing #1648

The changes have been made following these specifications:
open-telemetry/opentelemetry-specification#938
open-telemetry/opentelemetry-specification#956

Changed from:

  • NOT_RECORD

  • RECORD

  • RECORD_AND_SAMPLED

Changed to:

  • DROP

  • RECORD_ONLY

  • RECORD_AND_SAMPLE

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small doc suggestion for consistency, thanks!

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1661 into master will increase coverage by 0.05%.
The diff coverage is 91.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1661      +/-   ##
============================================
+ Coverage     86.62%   86.67%   +0.05%     
- Complexity     1398     1402       +4     
============================================
  Files           163      164       +1     
  Lines          5524     5545      +21     
  Branches        552      554       +2     
============================================
+ Hits           4785     4806      +21     
  Misses          542      542              
  Partials        197      197              
Impacted Files Coverage Δ Complexity Δ
...in/java/io/opentelemetry/metrics/DefaultMeter.java 100.00% <ø> (ø) 15.00 <0.00> (ø)
...in/java/io/opentelemetry/sdk/OpenTelemetrySdk.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
.../java/io/opentelemetry/sdk/internal/TestClock.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...telemetry/sdk/resources/EnvAutodetectResource.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...io/opentelemetry/sdk/metrics/MeterSdkProvider.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
.../io/opentelemetry/sdk/metrics/data/MetricData.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...metry/sdk/metrics/export/IntervalMetricReader.java 87.69% <ø> (ø) 4.00 <0.00> (ø)
...o/opentelemetry/sdk/metrics/view/Aggregations.java 76.78% <ø> (ø) 4.00 <0.00> (ø)
.../io/opentelemetry/sdk/trace/TracerSdkProvider.java 100.00% <ø> (ø) 11.00 <0.00> (ø)
...io/opentelemetry/sdk/trace/config/TraceConfig.java 95.00% <ø> (ø) 6.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cd21f...8f30bd7. Read the comment docs.

@jkwatson jkwatson merged commit 0ec2914 into open-telemetry:master Sep 18, 2020
dengliming pushed a commit to dengliming/opentelemetry-java that referenced this pull request Sep 19, 2020
* Changed all sampling result names

* Changed all sampling result names - spanbuilderSdkTest

* Changed all sampling result names

* Changed all sampling result names - spanbuilderSdkTest

* fixed formatting violations

* fixed formatting violations

* Update sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Sampler.java

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants