-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sampling result name #1661
Updated sampling result name #1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small doc suggestion for consistency, thanks!
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Sampler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1661 +/- ##
============================================
+ Coverage 86.62% 86.67% +0.05%
- Complexity 1398 1402 +4
============================================
Files 163 164 +1
Lines 5524 5545 +21
Branches 552 554 +2
============================================
+ Hits 4785 4806 +21
Misses 542 542
Partials 197 197
Continue to review full report at Codecov.
|
* Changed all sampling result names * Changed all sampling result names - spanbuilderSdkTest * Changed all sampling result names * Changed all sampling result names - spanbuilderSdkTest * fixed formatting violations * fixed formatting violations * Update sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Sampler.java Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
This PR updates the names of Sampling result for consistency, closing #1648
The changes have been made following these specifications:
open-telemetry/opentelemetry-specification#938
open-telemetry/opentelemetry-specification#956
Changed from:
NOT_RECORD
RECORD
RECORD_AND_SAMPLED
Changed to:
DROP
RECORD_ONLY
RECORD_AND_SAMPLE