Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception.escaped, clean up exception attributes javadoc. #1672

Merged

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Sep 22, 2020

This adds a semantic attribute key for exception.escaped as introduced in open-telemetry/opentelemetry-specification#784 (updated in open-telemetry/opentelemetry-specification#946).

It also cleans up the javadoc on the existing exception semantic attributes.

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #1672 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1672      +/-   ##
============================================
+ Coverage     86.42%   86.43%   +0.01%     
  Complexity     1384     1384              
============================================
  Files           162      162              
  Lines          5370     5376       +6     
  Branches        554      554              
============================================
+ Hits           4641     4647       +6     
  Misses          522      522              
  Partials        207      207              
Impacted Files Coverage Δ Complexity Δ
api/src/main/java/io/opentelemetry/trace/Span.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../main/java/io/opentelemetry/common/Attributes.java 96.66% <100.00%> (+0.11%) 17.00 <0.00> (ø)
...o/opentelemetry/common/ImmutableKeyValuePairs.java 98.24% <100.00%> (+0.03%) 24.00 <0.00> (ø)
...telemetry/trace/attributes/SemanticAttributes.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
.../java/io/opentelemetry/sdk/resources/Resource.java 90.00% <100.00%> (ø) 14.00 <0.00> (ø)
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 81.81% <100.00%> (+0.15%) 77.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f613da...47dde55. Read the comment docs.

@jkwatson jkwatson merged commit d9bd619 into open-telemetry:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants