Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document precedence order is multiple context propagators are used #1698

Conversation

malafeev
Copy link
Contributor

fix #1271

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1698 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1698      +/-   ##
============================================
- Coverage     85.51%   85.47%   -0.04%     
  Complexity     1442     1442              
============================================
  Files           177      177              
  Lines          5571     5571              
  Branches        578      578              
============================================
- Hits           4764     4762       -2     
- Misses          606      607       +1     
- Partials        201      202       +1     
Impacted Files Coverage Δ Complexity Δ
...context/propagation/DefaultContextPropagators.java 97.05% <ø> (ø) 3.00 <0.00> (ø)
...y/sdk/metrics/aggregator/DoubleMinMaxSumCount.java 95.91% <0.00%> (-4.09%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def5a23...b29b5a3. Read the comment docs.

@Oberon00
Copy link
Member

I think this is currently unspecified in the spec, as open-telemetry/opentelemetry-specification#496 is still open. If so, I think we should leave this unspecified in Java too to be able to follow the spec later without breaking documented behavior.

@jkwatson
Copy link
Contributor

I think this is currently unspecified in the spec, as open-telemetry/opentelemetry-specification#496 is still open. If so, I think we should leave this unspecified in Java too to be able to follow the spec later without breaking documented behavior.

ping @malafeev

@carlosalberto
Copy link
Contributor

I'm tempted to state/document here that the order is undefined for the time being. That way at least we are not tied for now ;) Does that sound right? If YES, @malafeev, you can iterate on this PR ;)

Sergei Malafeev added 2 commits October 20, 2020 20:24
@malafeev
Copy link
Contributor Author

updated

@jkwatson jkwatson merged commit 3670a69 into open-telemetry:master Oct 20, 2020
@malafeev malafeev deleted the document-order-defaultcontextpropagators branch March 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document precedence order is multiple context propagators are used
4 participants