-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OpenTelemetrySdk implement the OpenTelemetry interface and have SPI find it. #1857
Make OpenTelemetrySdk implement the OpenTelemetry interface and have SPI find it. #1857
Conversation
John has suggested using |
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=========================================
Coverage ? 85.56%
Complexity ? 1461
=========================================
Files ? 176
Lines ? 5679
Branches ? 593
=========================================
Hits ? 4859
Misses ? 616
Partials ? 204
Continue to review full report at Codecov.
|
Have you considered #1834? How would we solve this after this PR? (I did not think about it in depth yet -- maybe it gets easier) |
Added some comments in the issue - I am thinking that regardless we do want to have a single entry point into the SDK. It's the very common use case so presenting the single entry point simplifies the experience. But we may be able to improve the ux for custom sdk users by adding similar entry points into the SDK components. I don't believe that this change would hinder such improvements and want to make those with the understanding that we do want to optimize for the common case of full SDK if we ever make a trade-off. |
api/src/main/java/io/opentelemetry/spi/OpenTelemetryFactory.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/spi/OpenTelemetryFactory.java
Outdated
Show resolved
Hide resolved
examples/http/src/main/java/io/opentelemetry/example/http/HttpClient.java
Outdated
Show resolved
Hide resolved
examples/grpc/src/main/java/io/opentelemetry/example/HelloWorldServer.java
Outdated
Show resolved
Hide resolved
Thanks! This needs a few cleanups, but it's looking pretty solid to me. |
8e3229d
to
980644f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted QUICKSTART change since we'll do that with the release - copied it to https://gist.github.com/anuraaga/e53f5c226624b6efd83ceb276438ebd4
examples/http/src/main/java/io/opentelemetry/example/http/HttpClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
See #1737 for the discussion.
I don't want to merge a bad PR and a followup renaming like last time since it's confusing and a bit too tedious. I have two commits here, 949bfec is the significant one to check out, the other just applies renames.
Fixes #1109 (each app can have its own OpenTelemetry for different Resource which seems to be the crux of the issue)
Fixes #1149
Fixes #1454
Fixes #747