Change the default port that the OTLP exporters point to. #2113
Conversation
jkwatson
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2113 +/- ##
=============================================
+ Coverage 0 85.33% +85.33%
- Complexity 0 2117 +2117
=============================================
Files 0 241 +241
Lines 0 8086 +8086
Branches 0 893 +893
=============================================
+ Hits 0 6900 +6900
- Misses 0 854 +854
- Partials 0 332 +332
Continue to review full report at Codecov.
|
| @@ -111,8 +112,7 @@ private OtlpGrpcSpanExporter(ManagedChannel channel, long deadlineMs) { | |||
| */ | |||
| @Override | |||
| public CompletableResultCode export(Collection<SpanData> spans) { | |||
| spansSeen.add( | |||
| spans.size(), Labels.of("exporter", OtlpGrpcMetricExporter.class.getSimpleName())); | |||
| spansSeen.add(spans.size(), Labels.of("exporter", OtlpGrpcSpanExporter.class.getSimpleName())); | |||
There was a problem hiding this comment.
Thanks for the fixes! While we're here, should we extract constants for constant labels?
There was a problem hiding this comment.
Though as an aside, after seeing some metrics code recently, I sort of wish constant labels could be specified when creating a meter instead of only when observing to save the tedium of always extracting constants to save allocation
There was a problem hiding this comment.
This was a feature in the API that we decided to remove from the API for now. It may very well come back later, but we wanted to limit the features pre-GA, I think.
There was a problem hiding this comment.
yeah, I guess this could just be a constant for the labels instance, eh? Very happy to make that happen, either as a follow-up, or part of this PR.
There was a problem hiding this comment.
Either's fine with me this is approved :)
There was a problem hiding this comment.
easy enough to do, so I just amended this PR with the constant label extraction
jkwatson
force-pushed
the
change_collector_default_port
branch
from
b03b3fe to
3d68ff9
Compare
Resolves #2110