Add a test for the RECORD_ONLY span handling in the BatchSpanProcessor #2440
Conversation
And remove the old TODOs from the BSP test.
jkwatson
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2440 +/- ##
============================================
+ Coverage 88.56% 88.64% +0.07%
- Complexity 2638 2640 +2
============================================
Files 303 303
Lines 9026 9026
Branches 928 928
============================================
+ Hits 7994 8001 +7
+ Misses 708 700 -8
- Partials 324 325 +1
Continue to review full report at Codecov.
|
| */ | ||
| createEndedSpan(SPAN_NAME_2); | ||
|
|
||
| List<SpanData> exported = waitingSpanExporter.waitForExport(); |
There was a problem hiding this comment.
I think you need to do a similar pattern as the other test of exporting a sampled span after the record only span and checking it's the only exported span. Otherwise, this isn't doing any waiting I believe since nothing to wait for.
There was a problem hiding this comment.
The exporter is waiting for 1, and I was relying on the timeout to ensure nothing was getting through. Am I misunderstanding how the waiting exporter works?
And remove the old TODOs from the BSP test.
resolves #1588