Rename OtTracerPropagator to OtTracePropagator. #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
requested review from
anuraaga,
arminru,
bogdandrutu,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
|
you sure it shouldn't be "OtTracesPropagator"? |
bogdandrutu
approved these changes
Feb 5, 2021
|
@carlosalberto please fix the build |
Codecov Report
@@ Coverage Diff @@
## main #2718 +/- ##
===========================================
+ Coverage 0 89.57% +89.57%
- Complexity 0 2692 +2692
===========================================
Files 0 317 +317
Lines 0 8702 +8702
Branches 0 883 +883
===========================================
+ Hits 0 7795 +7795
- Misses 0 628 +628
- Partials 0 279 +279
Continue to review full report at Codecov.
|
anuraaga
reviewed
Feb 8, 2021
| @@ -62,8 +62,9 @@ private static TextMapPropagator getPropagator( | |||
| return B3Propagator.builder().injectMultipleHeaders().build(); | |||
| case "jaeger": | |||
| return JaegerPropagator.getInstance(); | |||
| // NB: https://github.com/open-telemetry/opentelemetry-specification/pull/1406 | |||
anuraaga
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to match the name in other SIGs and the name it will have in the Specification (see this).
Updated its small documentation piece as well.