update the semconv to v1.7.0 and the build tools to 0.7.0 #3686
Conversation
jkwatson
requested review from
anuraaga,
arminru,
bogdandrutu and
carlosalberto
as code owners
jkwatson
requested review from
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
| * implementations. | ||
| * </ul> | ||
| */ | ||
| public static final AttributeKey<Long> MESSAGE_ID = longKey("message.id"); |
There was a problem hiding this comment.
Interesting that this was not present previously. The attribute was there since a long time in the YAML.
There was a problem hiding this comment.
Looks like it was added here: open-telemetry/opentelemetry-specification#1843. By you. :)
There was a problem hiding this comment.
Oh, this is for RPC! Didn't realize... Yeah we should definitely change that name 😄
There was a problem hiding this comment.
Hmm, the id of the group is rpc.message, not just message. I thought id instead of prefix would be used for the name. But I guess that would lead to ugly identifiers in some cases where we split client/server into different groups. On the other hand, these identifiers may even be helpful.
Please consider that (well) before declaring the semconv artifact stable.
There was a problem hiding this comment.
For now, it may make sense to at least add the group ID to the generated javadoc, otherwise this documentation here is misleading, since the RPC context is completely missing.
There was a problem hiding this comment.
Is the group information even available to the templates at the moment? I poked around and tried various things but couldn't sort it out. It's very likely I missed it somewhere, though.
|
As far as I can tell the names we generate here match what's in the |
No description provided.