Deprecate InstrumentationLibraryInfo #4256
Conversation
| byte[] schemaUrlUtf8, | ||
| List<Marshaler> logMarshalers) { | ||
| int size = 0; | ||
| size += | ||
| MarshalerUtil.sizeMessage( | ||
| InstrumentationLibraryLogs.INSTRUMENTATION_LIBRARY, instrumentationLibrary); | ||
| InstrumentationLibraryLogs.INSTRUMENTATION_LIBRARY, instrumentationScope); |
There was a problem hiding this comment.
Just merged the proto update, so think you need to merge main and update the keys now when marshaling
There was a problem hiding this comment.
Actually, it looks like the proto PR to change the field names hasn't merged yet: open-telemetry/opentelemetry-proto#362
There was a problem hiding this comment.
Doh sorry for assuming without actually checking
| @@ -10,18 +10,21 @@ | |||
|
|
|||
| import org.junit.jupiter.api.Test; | |||
|
|
|||
| /** Tests for {@link InstrumentationLibraryInfo}. */ | |||
| /** Tests for {@link io.opentelemetry.sdk.common.InstrumentationLibraryInfo}. */ | |||
There was a problem hiding this comment.
Looks like some qualified imports got automatically added by intellij or something
There was a problem hiding this comment.
You have to qualify the imports, even in comments, or else you get an error for using deprecated classes.
There was a problem hiding this comment.
Ah thought if it's in the same package that wouldn't be an issue but maybe not
…y-java into deprecate-instrumentation-library
Codecov Report
@@ Coverage Diff @@
## main #4256 +/- ##
============================================
- Coverage 90.32% 90.19% -0.14%
- Complexity 4752 4753 +1
============================================
Files 553 554 +1
Lines 14611 14629 +18
Branches 1402 1403 +1
============================================
- Hits 13197 13194 -3
- Misses 954 975 +21
Partials 460 460
Continue to review full report at Codecov.
|
…y-java into deprecate-instrumentation-library
|
We all missed that this was a breaking change, since we added methods to public interfaces without a default implementation. :( |
Related to #4190.