Narrow ExtendedSpanBuilder return types for chaining #6514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6514 +/- ##
============================================
- Coverage 90.65% 90.63% -0.03%
- Complexity 6227 6228 +1
============================================
Files 678 679 +1
Lines 18659 18661 +2
Branches 1842 1842
============================================
- Hits 16916 16914 -2
- Misses 1187 1189 +2
- Partials 556 558 +2 ☔ View full report in Codecov by Sentry. |
laurit
reviewed
Jun 11, 2024
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkSpanBuilder.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jun 11, 2024
api/incubator/src/main/java/io/opentelemetry/api/incubator/trace/ExtendedSpanBuilder.java
Show resolved
Hide resolved
laurit
approved these changes
Jun 12, 2024
|
looks like you need to run the formatter on this to get rid of an unused import |
jkwatson
approved these changes
Jun 12, 2024
jack-berg
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this when updating open-telemetry/opentelemetry-java-examples#421