Add file configuration ComponentProvider support for resources #6625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6574.
In the issue, I said this about resources:
I had a change of heart in the implementation. Implementations of ResourceProvider expect to be participating in a configuration scenario which is based on the env var / system property configuration scheme. They receive a ConfigProperties instead of the StructuredConfigProperties used in file config, and look for things in it like
otel.resource.attributes
andotel.service.name
to influence their behavior.Instead, in this PR I use
ComponentProvider
to provide resource attributes. This will require me to go and update the various resource provider artifacts and implementComponentProvider
, but will be more precise, and more consistent with the clean separation approach we've been taking with file configuration.