Avoid allocations when advice doesn't remove any attributes #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6629 +/- ##
============================================
+ Coverage 90.19% 90.22% +0.02%
- Complexity 6281 6286 +5
============================================
Files 697 697
Lines 18903 18911 +8
Branches 1852 1852
============================================
+ Hits 17050 17062 +12
+ Misses 1281 1280 -1
+ Partials 572 569 -3 ☔ View full report in Codecov by Sentry. |
jack-berg
commented
Aug 7, 2024
| AttributesBuilder builder = incoming.toBuilder(); | ||
| builder.removeIf(key -> !attributeKeys.contains(key)); | ||
| return builder.build(); | ||
| } | ||
|
|
||
| /** Returns true if {@code attributes} has keys not contained in {@link #attributeKeys}. */ | ||
| private boolean hasExtraKeys(Attributes attributes) { | ||
| boolean[] result = {false}; |
There was a problem hiding this comment.
This little trick allows you to update state from inside a lambda without an atomic variable.
breedx-splk
approved these changes
Aug 7, 2024
jkwatson
approved these changes
Aug 8, 2024
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6601.