-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative configuration missing pieces #6677
Declarative configuration missing pieces #6677
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6677 +/- ##
============================================
- Coverage 90.03% 90.02% -0.02%
- Complexity 6317 6355 +38
============================================
Files 703 703
Lines 19074 19140 +66
Branches 1869 1887 +18
============================================
+ Hits 17174 17231 +57
- Misses 1324 1334 +10
+ Partials 576 575 -1 ☔ View full report in Codecov by Sentry. |
@@ -26,6 +26,7 @@ dependencies { | |||
|
|||
// io.opentelemetry.sdk.extension.incubator.fileconfig | |||
implementation("com.fasterxml.jackson.core:jackson-databind") | |||
api("com.fasterxml.jackson.core:jackson-annotations") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, open-telemetry/opentelemetry-java-contrib#1440 is full of warnings like:
/Users/jberg/.m2/repository/io/opentelemetry/opentelemetry-sdk-extension-incubator/1.42.0-alpha-SNAPSHOT/opentelemetry-sdk-extension-incubator-1.42.0-alpha-SNAPSHOT.jar(/io/opentelemetry/sdk/extension/incubator/fileconfig/internal/model/OpenTelemetryConfiguration.class): warning: Cannot find annotation method 'value()' in type 'JsonProperty'
public static StructuredConfigProperties toConfigProperties(InputStream configuration) { | ||
Object yamlObj = loadYaml(configuration, System.getenv()); | ||
return toConfigProperties(yamlObj); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an essential test utility, allowing you to write chunks of YAML, convert them to StructuredConfigProperties, and call ComponentProvider, i.e. https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1440/files#diff-3d0118f231281243bf34a7e7beb3809e7a6523e8ece8a17b83f1784953389ceb
...java/io/opentelemetry/sdk/extension/incubator/fileconfig/YamlStructuredConfigProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #6574.
Little things discovered implementing open-telemetry/opentelemetry-java-contrib#1440.