Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codify stance against using java-test-fixtures plugin #6696

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jack-berg
Copy link
Member

See #6695 (comment):

In hindsight, adding java-test-fixtures was overly hasty, since as shown in #6693 it impacts the pom.xml and publishes additional artifacts we didn't intend / account for. When we need to share test code in this repository, we simply add a *:testing-internal module and omit the otel.publish-conventions. I suspect this pattern was selected in the past after investigating test fixtures and seeing these types of side affects.

@jack-berg jack-berg requested a review from a team September 9, 2024 15:14
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (b0643fe) to head (a35e63b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6696   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity     6390     6390           
=========================================
  Files           711      711           
  Lines         19333    19333           
  Branches       1891     1891           
=========================================
  Hits          17418    17418           
  Misses         1335     1335           
  Partials        580      580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 8fb169e into open-telemetry:main Sep 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants