Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding model as suffix to generated classes. #6721

Merged

Conversation

vasantteja
Copy link
Contributor

@vasantteja vasantteja commented Sep 13, 2024

This Change

We are adding model as suffix to all the generated classes. This pr resolves 6676

Copy link

linux-foundation-easycla bot commented Sep 13, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (f85a57b) to head (5c6e91e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6721      +/-   ##
============================================
- Coverage     90.11%   90.08%   -0.03%     
+ Complexity     6392     6390       -2     
============================================
  Files           711      711              
  Lines         19333    19333              
  Branches       1891     1891              
============================================
- Hits          17421    17417       -4     
- Misses         1333     1335       +2     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vasantteja vasantteja marked this pull request as ready for review September 13, 2024 02:42
@vasantteja vasantteja requested a review from a team September 13, 2024 02:42
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for picking this up!

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit 9249653 into open-telemetry:main Sep 18, 2024
18 checks passed
@vasantteja vasantteja deleted the model-suffix-for-generated-classes branch October 16, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Model" suffix to declarative configuration generated types
3 participants