-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilizing otel.experimental.resource.disabled.keys
#6809
Stabilizing otel.experimental.resource.disabled.keys
#6809
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6809 +/- ##
============================================
+ Coverage 90.36% 90.37% +0.01%
- Complexity 6576 6579 +3
============================================
Files 731 731
Lines 19714 19720 +6
Branches 1926 1928 +2
============================================
+ Hits 17814 17822 +8
+ Misses 1302 1300 -2
Partials 598 598 ☔ View full report in Codecov by Sentry. |
...ns/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, we'll need to update the autoconfigure docs on opentelemetry.io when this is released.
Yeah I was thinking of updating the docs and creating another feature to deprecate the experimental feature in next major release. How does this sound? |
I opened #6811 to add "updating the docs" as a release step, so I can go ahead and update the docs when I do the next release. If we were to go update the docs now, users might get confused because the new property name isn't actually released yet. As for deprecating the experimental property name, I'd say that this PR is the deprecation. We typically keep deprecated experimental features around a couple of minor releases, but no reason to wait for a major release to do this. We have no plans to release a new major version so waiting for this would essentially be waiting indefinitely. |
...ns/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider being explicit about when we plan to remove, but otherwise looks good. Thanks!
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
I kept
otel.experimental.resource.disabled.keys
for backwards compatibility and promoted them to a newer stabilized version asotel.resource.disabled.keys
. Please take a look and let me know if this looks good. This resolves 6777