Stabilizing otel.experimental.resource.disabled.keys

[vasantteja]

I kept otel.experimental.resource.disabled.keys for backwards compatibility and promoted them to a newer stabilized version as otel.resource.disabled.keys. Please take a look and let me know if this looks good. This resolves 6777

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (680c940) to head (453d282).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6809      +/-   ##
============================================
+ Coverage     90.36%   90.37%   +0.01%     
- Complexity     6576     6579       +3     
============================================
  Files           731      731              
  Lines         19714    19720       +6     
  Branches       1926     1928       +2     
============================================
+ Hits          17814    17822       +8     
+ Misses         1302     1300       -2     
  Partials        598      598              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jack-berg]

Note, we'll need to update the autoconfigure docs on opentelemetry.io when this is released.

[vasantteja]

Note, we'll need to update the autoconfigure docs on opentelemetry.io when this is released.

Yeah I was thinking of updating the docs and creating another feature to deprecate the experimental feature in next major release. How does this sound?

[jack-berg]

Yeah I was thinking of updating the docs and creating another feature to deprecate the experimental feature in next major release. How does this sound?

I opened #6811 to add "updating the docs" as a release step, so I can go ahead and update the docs when I do the next release. If we were to go update the docs now, users might get confused because the new property name isn't actually released yet.

As for deprecating the experimental property name, I'd say that this PR is the deprecation. We typically keep deprecated experimental features around a couple of minor releases, but no reason to wait for a major release to do this. We have no plans to release a new major version so waiting for this would essentially be waiting indefinitely.

[jack-berg]

How about we warn users that it will be removed after the 1.45.0 release, which is 3 releases?

Suggested change

	"otel.experimental.resource.disabled.keys is deprecated. Please use otel.resource.disabled.keys instead.");
	"otel.experimental.resource.disabled.keys is deprecated and will be removed after 1.45.0 release. Please use otel.resource.disabled.keys instead.");

[jack-berg]

Consider being explicit about when we plan to remove, but otherwise looks good. Thanks!