Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error prone checks for internal javadoc and private constructors #6844

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

jack-berg
Copy link
Member

Ports build automation from opentelemetry-java-instrumentation/custom-checks to add additional custom error prone checks

  • Ensure that utility classes have private constructors
  • Ensure public internal classes have standard boilerplate

Resolves #6798.

@jack-berg jack-berg requested a review from a team as a code owner October 31, 2024 18:29
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (2e8bf7f) to head (c8f04ed).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6844      +/-   ##
============================================
- Coverage     90.49%   90.49%   -0.01%     
  Complexity     6598     6598              
============================================
  Files           731      731              
  Lines         19735    19735              
  Branches       1938     1938              
============================================
- Hits          17860    17859       -1     
  Misses         1283     1283              
- Partials        592      593       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.javaagent.customchecks;
Copy link
Contributor

@laurit laurit Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you deliberately keep the javaagent package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good catch!

@jack-berg jack-berg merged commit e4f3978 into open-telemetry:main Nov 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build automation to ensure internal classes have required javadoc boilerplate
2 participants