Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DistributedContext to CorrelationContext #757

Merged

Conversation

carlosalberto
Copy link
Contributor

This is done In order to help merging OTEP 66 and get #720 merged.

This PR is also solely focusing on the rename, to keep things logically separated, to to speak (further improvements should be done in separated PRs or in the aforementioned PR itself ;) )

@codecov-io
Copy link

Codecov Report

Merging #757 into master will decrease coverage by 0.03%.
The diff coverage is 93.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #757      +/-   ##
===========================================
- Coverage     78.34%   78.3%   -0.04%     
  Complexity      761     761              
===========================================
  Files            97      97              
  Lines          2701    2701              
  Branches        247     247              
===========================================
- Hits           2116    2115       -1     
  Misses          488     488              
- Partials         97      98       +1
Impacted Files Coverage Δ Complexity Δ
.../opentelemetry/opentracingshim/BaseShimObject.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...ava/io/opentelemetry/correlationcontext/Entry.java 100% <ø> (ø) 3 <0> (?)
.../io/opentelemetry/correlationcontext/EntryKey.java 100% <ø> (ø) 6 <0> (?)
...pentelemetry/correlationcontext/EntryMetadata.java 88.88% <ø> (ø) 2 <0> (?)
...o/opentelemetry/correlationcontext/EntryValue.java 100% <ø> (ø) 5 <0> (?)
...elemetry/opentracingshim/SpanContextShimTable.java 89.28% <100%> (ø) 7 <1> (ø) ⬇️
...o/opentelemetry/opentracingshim/TelemetryInfo.java 100% <100%> (ø) 5 <2> (ø) ⬇️
...ationcontext/unsafe/CorrelationContextInScope.java 100% <100%> (ø) 3 <2> (?)
...opentelemetry/opentracingshim/SpanBuilderShim.java 53.68% <100%> (ø) 22 <10> (ø) ⬇️
...ncontext/CorrelationContextManagerSdkProvider.java 100% <100%> (ø) 2 <2> (?)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54a4e9...d61b1f0. Read the comment docs.

@carlosalberto
Copy link
Contributor Author

@open-telemetry/java-approvers please review, I'd like this one get merged it rather soon (if possible) ;)

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick scan looks like this is a 👍 If you missed any, we can circle back and pick them up later.

@bogdandrutu bogdandrutu merged commit 5dfe74e into open-telemetry:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants