Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracerProvider: Make format settable. #914

Conversation

Oberon00
Copy link
Member

Resolves #718.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c802811). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #914   +/-   ##
=========================================
  Coverage          ?   82.74%           
  Complexity        ?      841           
=========================================
  Files             ?      113           
  Lines             ?     2968           
  Branches          ?      252           
=========================================
  Hits              ?     2456           
  Misses            ?      399           
  Partials          ?      113
Impacted Files Coverage Δ Complexity Δ
...ntelemetry/trace/propagation/HttpTraceContext.java 94.66% <100%> (ø) 17 <1> (?)
...elemetry/trace/propagation/BinaryTraceContext.java 100% <100%> (ø) 13 <1> (?)
...ain/java/io/opentelemetry/sdk/trace/TracerSdk.java 100% <100%> (ø) 8 <2> (?)
.../io/opentelemetry/sdk/trace/TracerSdkProvider.java 100% <100%> (ø) 10 <1> (?)
.../io/opentelemetry/sdk/trace/TracerSharedState.java 94.11% <100%> (ø) 12 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c802811...863dc35. Read the comment docs.

@carlosalberto
Copy link
Contributor

carlosalberto commented Feb 24, 2020

I don't think we want this feature anymore - based on OTEP 66, now the default Propagators will be set by the API, and the user will be able to override them (removing the instances from both Tracer and CorrelationContext).

@Oberon00
Copy link
Member Author

Hi @carlosalberto, I know this feature is mostly obsoleted by OTEP 66, but it seems that it will take some time until this is implemented, so I wanted to provide this PR as a remedy in the meantime. I do think, however, that we'd want to have the propagators configurable via the builder even after OTEP 66 has landed in java.

@carlosalberto
Copy link
Contributor

So we really need OTEP 66 changes for the beta (March 16th). As mentioned in the related PR, now that I have my hands a little free-r, we should be able to keep that feature ready/merged relatively soon (I hope we get most of the things done/ready this week TBH).

I'd put a "Holding on" on this issue while we work on that one, and decide to apply this if for some reason we can't get it merged in 1-2 weeks.

@bogdandrutu
Copy link
Member

@Oberon00 is this obsolete now?

@Oberon00
Copy link
Member Author

I'm not sure. How would you set a custom text format with the new API? I'll look it up.

@Oberon00
Copy link
Member Author

That is to say, this PR is certainly obsolete now, but I'll need to check if #718 can be closed.

@Oberon00 Oberon00 closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to change HttpTextFormat
6 participants