-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TracerProvider: Make format settable. #914
TracerProvider: Make format settable. #914
Conversation
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
=========================================
Coverage ? 82.74%
Complexity ? 841
=========================================
Files ? 113
Lines ? 2968
Branches ? 252
=========================================
Hits ? 2456
Misses ? 399
Partials ? 113
Continue to review full report at Codecov.
|
I don't think we want this feature anymore - based on OTEP 66, now the default |
Hi @carlosalberto, I know this feature is mostly obsoleted by OTEP 66, but it seems that it will take some time until this is implemented, so I wanted to provide this PR as a remedy in the meantime. I do think, however, that we'd want to have the propagators configurable via the builder even after OTEP 66 has landed in java. |
So we really need OTEP 66 changes for the beta (March 16th). As mentioned in the related PR, now that I have my hands a little free-r, we should be able to keep that feature ready/merged relatively soon (I hope we get most of the things done/ready this week TBH). I'd put a "Holding on" on this issue while we work on that one, and decide to apply this if for some reason we can't get it merged in 1-2 weeks. |
@Oberon00 is this obsolete now? |
I'm not sure. How would you set a custom text format with the new API? I'll look it up. |
That is to say, this PR is certainly obsolete now, but I'll need to check if #718 can be closed. |
Resolves #718.