This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Docs: Document the HrTime format #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesJHPark
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rauno56 and
vmarchaud
as code owners
Flarna
approved these changes
Nov 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 42 42
Lines 578 578
Branches 94 94
=======================================
Hits 546 546
Misses 32 32 Continue to review full report at Codecov.
|
legendecas
approved these changes
Nov 8, 2021
|
@JamesJHPark You'll need to rebase the PR (and if you want address legendecas's comment) |
vmarchaud
approved these changes
Nov 8, 2021
obecny
approved these changes
Nov 8, 2021
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address and document the HrTime format,
HrTime = [number, number], to specify the representation of the first and second number.-related to issue #2578 in opentelemetry-js