Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: update actions/checkout to v2 #146

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 27, 2021

Fixes #144

@dyladan dyladan requested a review from a team December 27, 2021 15:15
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #146 (9723cd1) into main (80d617b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          42       42           
  Lines         578      578           
  Branches       94       94           
=======================================
  Hits          546      546           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d617b...9723cd1. Read the comment docs.

@vmarchaud
Copy link
Member

Is this ready to review since there are debug ls in the workflows ? I believe not but i'm not sure

@dyladan
Copy link
Member Author

dyladan commented Dec 27, 2021

@vmarchaud I opened it as "ready" initially because it seemed so obvious, but i can't get the test to pass on browser or node 16. I'm getting weird permission errors even though the result of id shows that we are running as root.

@dyladan dyladan marked this pull request as draft December 27, 2021 19:49
@dyladan dyladan marked this pull request as ready for review December 27, 2021 21:00
@dyladan
Copy link
Member Author

dyladan commented Dec 27, 2021

@vmarchaud it is now ready

@dyladan dyladan force-pushed the update-checkout branch 2 times, most recently from cb0f99c to a65444f Compare December 28, 2021 14:05
@dyladan dyladan merged commit 474f853 into open-telemetry:main Dec 28, 2021
@dyladan dyladan deleted the update-checkout branch December 28, 2021 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Workflow test.yaml is using vulnerable action actions/checkout
4 participants