This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 42 42
Lines 578 578
Branches 94 94
=======================================
Hits 546 546
Misses 32 32 Continue to review full report at Codecov.
|
naseemkullah
approved these changes
Dec 27, 2021
Is this ready to review since there are debug |
@vmarchaud I opened it as "ready" initially because it seemed so obvious, but i can't get the test to pass on browser or node 16. I'm getting weird permission errors even though the result of |
d0a9fc5
to
e349105
Compare
e2bf114
to
93e01e1
Compare
@vmarchaud it is now ready |
93e01e1
to
39f801b
Compare
vmarchaud
reviewed
Dec 27, 2021
cb0f99c
to
a65444f
Compare
a65444f
to
c01a9b2
Compare
legendecas
approved these changes
Dec 28, 2021
d45248b
to
9723cd1
Compare
vmarchaud
approved these changes
Dec 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144