-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 45 45
Lines 650 650
Branches 102 102
=======================================
Hits 619 619
Misses 31 31 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@open-telemetry/javascript-maintainers this would require the latest SDK in oder to be used because the minor version is updated. Should we instead release this as 1.1.1? It is not a bug fix, but it is strictly compatible with the previous SDK version. |
Lint check fails because the link to the release is broken until the release is made. |
Why should we violate semver? If some instrumentation uses the new API it should depend on 1.2.0 to clearly indicated that it can't work with 1.1.x. There is compatibility with old SDK but not with old API. |
I have no good argument to break the semver semantics. Notably, in our docs, we always ignore the patch bit in the semver: https://github.com/open-telemetry/opentelemetry-js#compatibility-matrix. I found @Flarna's point is fair. |
OK sounds good |
@dyladan what are the next steps here? The API docs we point people towards are up to date w.r.t. 1.2: https://open-telemetry.github.io/opentelemetry-js-api/interfaces/tracer.html But there's no corresponding 1.2 package on npmjs that people can use. |
Heh, whoopsie. Hmm. Weird that it doesn't pop up when I search for it? https://www.npmjs.com/package/@opentelemetry/api (points to 1.1 for me) |
1.2 has the |
We're discussing merging the API and SDK repositories back into a single repo so we can link everything with lerna and release all at once in order to avoid this issue in the future. It will also help with developing new API features. |
Awesome, thank you! I will track that for now (my intent is to update docs for both otel and honeycomb once this is in place). |
👋🏻 noticed everything's been merged and released - is there anything else needed to get the tag updated for the API package? |
🤖 I have created a release *beep* *boop*
1.2.0 (2022-08-09)
Features
This PR was generated with Release Please. See documentation.