-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 94.70% 94.66% -0.05%
==========================================
Files 42 42
Lines 567 562 -5
Branches 94 94
==========================================
- Hits 537 532 -5
Misses 30 30
Continue to review full report at Codecov.
|
I know that the headline tells do not export singletons. But above I read Currently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the followup PR in core will be funny :o).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks fine, but before this one is merged, we should first update core and contrib to avoid problems with being unable to make a release of those packages for a long time. Merging this PR should be a last thing in this task
Fixes #38