Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: export baggage #71

Merged
merged 7 commits into from
May 20, 2021
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 18, 2021

Baggage types were not exported

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #71 (16f6d98) into main (8bd1c6e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   94.99%   95.00%   +0.01%     
==========================================
  Files          41       42       +1     
  Lines         559      561       +2     
  Branches       94       94              
==========================================
+ Hits          531      533       +2     
  Misses         28       28              
Impacted Files Coverage Δ
src/baggage/internal/baggage-impl.ts 96.15% <ø> (ø)
src/api/propagation.ts 100.00% <100.00%> (ø)
src/baggage/context-helpers.ts 100.00% <100.00%> (ø)
src/baggage/utils.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd1c6e...16f6d98. Read the comment docs.

src/baggage/index.ts Outdated Show resolved Hide resolved
src/baggage/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine now, just wait for confirmation yet from @vmarchaud yet

@dyladan dyladan merged commit 77b8c34 into open-telemetry:main May 20, 2021
@dyladan dyladan deleted the export-baggage branch May 20, 2021 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants