This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
chore: remove nycrc in favor of tsconfig reporting #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 89.82% 94.27% +4.45%
==========================================
Files 33 35 +2
Lines 452 489 +37
Branches 77 78 +1
==========================================
+ Hits 406 461 +55
+ Misses 46 28 -18
Continue to review full report at Codecov.
|
Flarna
approved these changes
Feb 23, 2021
obecny
approved these changes
Feb 23, 2021
vmarchaud
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nycrc file was causing the coverage reports to include a bunch of files we don't necessarily want. Removing it allows the tsconfig to be used which is actually the important coverage of the project.