feat(instrumentation-aws-sdk)!: Capture full ARN for span attribute m…

…essaging.destination.name for SNS topics (#1727)

* Capture full ARN for SNS topics in messaging.destination

Problem:
The use of topic names instead of ARNs in `messaging.destination` omits
essential account information, making topic localization cumbersome.

Solution:
Adopt full ARNs as the value for `messaging.destination`, preserving both
topic name and account details, aligning with current SNS ServiceExtension
approach.

Closes #1716

* Add new span attribute instead of modifying the existing attribute

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>

plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/sns.ts

@@ -42,6 +42,9 @@ export class SnsServiceExtension implements ServiceExtension {
  const { TopicArn, TargetArn, PhoneNumber } = request.commandInput;
  spanAttributes[SemanticAttributes.MESSAGING_DESTINATION] =
  this.extractDestinationName(TopicArn, TargetArn, PhoneNumber);
+ // ToDO: Use SpanAttributes.MESSAGING_DESTINATION_NAME when implemented
+ spanAttributes['messaging.destination.name'] =
+ TopicArn || TargetArn || PhoneNumber || 'unknown';
 
  spanName = `${
  PhoneNumber

plugins/node/opentelemetry-instrumentation-aws-sdk/test/sns.test.ts

@@ -84,6 +84,9 @@ describe('SNS - v2', () => {
  expect(
  publishSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
  ).toBe(topicName);
+ expect(publishSpan.attributes['messaging.destination.name']).toBe(
+ fakeARN
+ );
  expect(publishSpan.attributes[SemanticAttributes.RPC_METHOD]).toBe(
  'Publish'
  );
@@ -111,6 +114,9 @@ describe('SNS - v2', () => {
  expect(
  publishSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
  ).toBe(PhoneNumber);
+ expect(publishSpan.attributes['messaging.destination.name']).toBe(
+ PhoneNumber
+ );
  });
 
  it('inject context propagation', async () => {
@@ -159,6 +165,9 @@ describe('SNS - v2', () => {
  expect(
  createTopicSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
  ).toBeUndefined();
+ expect(
+ createTopicSpan.attributes['messaging.destination.name']
+ ).toBeUndefined();
  expect(createTopicSpan.kind).toBe(SpanKind.CLIENT);
  });
  });
@@ -186,9 +195,11 @@ describe('SNS - v3', () => {
  describe('publish', () => {
  it('topic arn', async () => {
  const topicV3Name = 'dummy-sns-v3-topic';
+ const topicV3ARN = `arn:aws:sns:us-east-1:000000000:${topicV3Name}`;
+
  await sns.publish({
  Message: 'sns message',
- TopicArn: `arn:aws:sns:us-east-1:000000000:${topicV3Name}`,
+ TopicArn: topicV3ARN,
  });
 
  const publishSpans = getTestSpans().filter(
@@ -203,6 +214,9 @@ describe('SNS - v3', () => {
  expect(
  publishSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
  ).toBe(topicV3Name);
+ expect(publishSpan.attributes['messaging.destination.name']).toBe(
+ topicV3ARN
+ );
  expect(publishSpan.attributes[SemanticAttributes.RPC_METHOD]).toBe(
  'Publish'
  );