test(resource-detector-alibaba-cloud): revert change, disable tests f…

…or node@18
open-telemetry · Sep 9, 2022 · a29dcd3 · a29dcd3
1 parent 654932f
commit a29dcd3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -10,6 +10,11 @@ jobs:
  fail-fast: false
  matrix:
  node: ["14", "16", "18"]
+ include:
+ # tests fail on node@18, incompatibility with nock?
+ - node: "18"
+ lerna-extra-args: >-
+ --ignore @opentelemetry/resource-detector-alibaba-cloud
  runs-on: ubuntu-latest
  services:
  memcached:

diff --git a/...de/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts b/...de/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
@@ -114,7 +114,7 @@ class AlibabaCloudEcsDetector implements Detector {
  typeof statusCode !== 'number' ||
  !(statusCode >= 200 && statusCode < 300)
  ) {
- res.socket.destroy();
+ res.destroy();
  return reject(
  new Error(`Failed to load page, status code: ${statusCode}`)
  );