-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codecov] coverage not reported correctly on main
#1473
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@pichlermarc @blumamir I double check 2 latest commit on main and seem like there are still some issue as codecov randomly unable to upload our code coverage file.
This can be fix by adding token key to codecov-action, due to some quota limiting on Github side. But this will require change to repo's settings + admin access to codecov's dashboard to get the token.
This comment from codecov-action's repo list out the pro/cons of expose this token value as public variable vs secret: |
What version of OpenTelemetry are you using?
codecov
is not reporting coverage correctly on main and most PRs. It's only detecting906
lines, and looks like it's only using the browser test reports, whereas some PRs detect more lines (4706
), including thenode
test reports as well, which is the intended amount.What did you do?
Created a PR (#1468), had the pipeline run there - the
codecov
step failed with many indirect coverage changes.What did you expect to see?
codecov
detecting all lines in the report onmain
, not only the ones hit inbrowser
tests.What did you see instead?
codecov
reports only include files used inbrowser
tests onmain
.Additional context
renovate/otel-core-experimental branch's coverage report (detecting 4706 lines and including detectors)

main branch's coverage report (detecting only 906 lines)

The text was updated successfully, but these errors were encountered: