Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@opentelemetry/instrumentation-graphql's unit test pipeline not working correctly #1594

Closed
chigia001 opened this issue Jul 17, 2023 · 4 comments · Fixed by #1605
Closed

@opentelemetry/instrumentation-graphql's unit test pipeline not working correctly #1594

chigia001 opened this issue Jul 17, 2023 · 4 comments · Fixed by #1605
Assignees
Labels
bug Something isn't working priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization

Comments

@chigia001
Copy link
Contributor

chigia001 commented Jul 17, 2023

What version of OpenTelemetry are you using?

  • @opentelemetry/instrumentation-graphql@0.35.0

What version of Node are you using?

  • >=14 <=18

What did you do?

  • Run unit test in current repo on github action

What did you expect to see?

  • @opentelemetry/instrumentation-graphql's unit test run correctly and return list of test + code coverage report

What did you see instead?

lerna info run Ran npm script 'test' in '@opentelemetry/instrumentation-graphql' in 49.4s:

> @opentelemetry/instrumentation-graphql@0.35.0 test /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-graphql
> nyc ts-mocha -p tsconfig.json 'test/**/*.test.ts'

------------|---------|----------|---------|---------|-------------------
File        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------|---------|----------|---------|---------|-------------------
All files   |       0 |      100 |     100 |       0 |                   
 symbols.ts |       0 |      100 |     100 |       0 | 17-19             
------------|---------|----------|---------|---------|-------------------

Additional context

  • I double check those test on local machine and unable to repproduce this behavior. There are no crash or anything.
  • I able to reproduce with codespace, seem like nyc issue when they trying to transform code for codecoverage report. When running ts-mocha without nyc everything seem to work.
@chigia001 chigia001 added the bug Something isn't working label Jul 17, 2023
@chigia001
Copy link
Contributor Author

chigia001 commented Jul 17, 2023

@haddasbronfman I think you also face similar problem with mongodb test with #1487 . I will try to switch from ts-mocha to mocha + ts-node like their suggest https://typestrong.org/ts-node/docs/recipes/mocha/ to see if it resolve the issue

@haddasbronfman
Copy link
Member

@chigia001 in my case I think also the problem is because of nyc, although in my case I saw an empty table.

@dyladan dyladan added the priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization label Jul 19, 2023
@dyladan
Copy link
Member

dyladan commented Jul 19, 2023

@chigia001 is it ok if I assign this to you since you have a PR open?

@chigia001
Copy link
Contributor Author

@dyladan yes, I think some hoist issue with current setup, will try to come up with smaller PR tmr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization
Projects
None yet
3 participants