Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb version3 tests are not running #1487

Closed
haddasbronfman opened this issue May 4, 2023 · 1 comment · Fixed by #1605
Closed

mongodb version3 tests are not running #1487

haddasbronfman opened this issue May 4, 2023 · 1 comment · Fixed by #1605
Assignees
Labels
bug Something isn't working internal pkg:instrumentation-mongodb priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization

Comments

@haddasbronfman
Copy link
Member

haddasbronfman commented May 4, 2023

What did you do?

on the main branch, mongodb tests are not running:
image

@pichlermarc has noticed it while reviewing mongodb metrics PR.

What did you expect to see?

I expected mongodb tests will run as part of the unit-test github action

What did you see instead?

they don't run

Additional context

  1. we decided to merge the PR in which we found the issue because it seem unrelated.
  2. A wild guess - this happened when we added instrumentation for mongodb version 4.. But this still need to be checked.
  3. I reproduced it locally and saw this log:

> @opentelemetry/instrumentation-mongodb@0.34.3 test
> nyc ts-mocha -p tsconfig.json --require '@opentelemetry/contrib-test-utils' 'test/**/mongodb-v3.test.ts'


<--- Last few GCs --->

[33509:0x110008000]   166585 ms: Scavenge (reduce) 4065.7 (4074.8) -> 4065.2 (4075.1) MB, 9.2 / 0.0 ms  (average mu = 0.257, current mu = 0.253) allocation failure 
[33509:0x110008000]   166596 ms: Scavenge (reduce) 4066.0 (4072.1) -> 4065.4 (4073.1) MB, 8.8 / 0.0 ms  (average mu = 0.257, current mu = 0.253) allocation failure 
[33509:0x110008000]   166646 ms: Scavenge (reduce) 4066.1 (4072.1) -> 4065.6 (4073.3) MB, 47.5 / 0.0 ms  (average mu = 0.257, current mu = 0.253) allocation failure 


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x10131a2c5 node::Abort() (.cold.1) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 2: 0x1000b61d9 node::Abort() [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 3: 0x1000b634f node::OnFatalError(char const*, char const*) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 4: 0x100200d27 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 5: 0x100200cc3 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 6: 0x1003aedd5 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 7: 0x1003b087a v8::internal::Heap::RecomputeLimits(v8::internal::GarbageCollector) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 8: 0x1003abfa5 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
 9: 0x1003a98d0 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
10: 0x1003b7ffa v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
11: 0x1003b8081 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
12: 0x100385e52 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
13: 0x1007062f0 v8::internal::Runtime_AllocateInOldGeneration(int, unsigned long*, v8::internal::Isolate*) [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
14: 0x100a8e039 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/Users/haddasb/.nvm/versions/node/v14.18.3/bin/node]
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------
@haddasbronfman
Copy link
Member Author

Seems like the problem is in nyc. I opened a bug: istanbuljs/nyc#1525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment