feat(mongodb): collect mongodb4 metrics #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osherv
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
- Coverage 96.13% 95.38% -0.76%
==========================================
Files 14 16 +2
Lines 906 997 +91
Branches 197 206 +9
==========================================
+ Hits 871 951 +80
- Misses 35 46 +11 |
…emetry-js-contrib into feat/add-mongodb-metrics
osherv
changed the title
|
Do you want to wait for open-telemetry/opentelemetry-js#3267 to merge this ? |
|
@vmarchaud Yea, probably, thanks :) |
|
Converting to draft in the mean time :) |
|
@legendecas @dyladan Hi. I'm looking for reviewers who are familiar with metrics. Can you please review this PR? |
pichlermarc
reviewed
May 2, 2023
plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v4.metrics.test.ts
Outdated
Show resolved
Hide resolved
…emetry-js-contrib into feat/add-mongodb-metrics
legendecas
approved these changes
May 4, 2023
| const inMemoryMetricsExporter = new InMemoryMetricExporter( | ||
| AggregationTemporality.CUMULATIVE | ||
| ); | ||
| const metricReader = new PeriodicExportingMetricReader({ |
There was a problem hiding this comment.
Nit: IIUC, a pulling metric reader might be better suited for testing usage since it can pull metrics proactively instead of awaiting timeouts.
pichlermarc
reviewed
May 4, 2023
plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v4.metrics.test.ts
Outdated
Show resolved
Hide resolved
…b-v4.metrics.test.ts Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
|
Looks like TAV is failing on line 137 in the v4 metrics tests, the idle state is now exporting |
…emetry-js-contrib into feat/add-mongodb-metrics
Merged
sberz
added a commit
to sberz/opentelemetry-js-contrib
that referenced
this pull request
Aug 18, 2023
The type `V4Connection` re-introduced in open-telemetry#1170 is missing any type definitions or imports for `Document`, breaking the build with typecricpt strict mode. `V4Connection` in `types.ts` is not referenced anywhere (the type definition in `internal-types.ts` is used. So lets just drop this type definition. BREAKING CHANGE: removes the broken exported type `V4Connection`. Fixes open-telemetry#1639
sberz
added a commit
to sberz/opentelemetry-js-contrib
that referenced
this pull request
Aug 18, 2023
The type `V4Connection` re-introduced in open-telemetry#1170 is missing any type definitions or imports for `Document`, breaking the build with Typescript strict mode. `V4Connection` in `types.ts` is not referenced anywhere (the type definition in `internal-types.ts` is used. So lets just drop this type definition. BREAKING CHANGE: removes the broken exported type `V4Connection`. Fixes open-telemetry#1639
sberz
added a commit
to sberz/opentelemetry-js-contrib
that referenced
this pull request
Aug 18, 2023
The type `V4Connection` re-introduced in open-telemetry#1170 is missing any type definitions or imports for `Document`, breaking the build with Typescript strict mode. `V4Connection` in `types.ts` is not referenced anywhere (the type definition in `internal-types.ts` is used. So lets just drop this type definition. BREAKING CHANGE: removes the broken exported type `V4Connection`. Fixes open-telemetry#1639 Signed-off-by: Simon Berz <simon@berz.me>
blumamir
pushed a commit
that referenced
this pull request
Aug 26, 2023
The type `V4Connection` re-introduced in #1170 is missing any type definitions or imports for `Document`, breaking the build with Typescript strict mode. `V4Connection` in `types.ts` is not referenced anywhere (the type definition in `internal-types.ts` is used. So lets just drop this type definition. BREAKING CHANGE: removes the broken exported type `V4Connection`. Fixes #1639 Signed-off-by: Simon Berz <simon@berz.me>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Fixes #1157
Added metrics collection for MongoDB >= 4, according to:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/database-metrics.md
This is the first of many contributions planned under metrics collections at the instrumentation level, so I'll be really happy to get as much as comments as we can on this :)
Thanks!
Checklist
npm run test-all-versionsfor the edited package(s) on the latest commit if applicable.