Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set files field in all of our package.json files #820

Closed
2 tasks
rauno56 opened this issue Jan 4, 2022 · 3 comments · Fixed by #1786
Closed
2 tasks

Set files field in all of our package.json files #820

rauno56 opened this issue Jan 4, 2022 · 3 comments · Fixed by #1786
Assignees
@macno
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest enhancement New feature or request good first issue internal never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@rauno56
Copy link
Member

rauno56 commented Jan 4, 2022

files field defines which files ought to be included in the final published package.

  • set files for all the package.json files. Don't include files always included, remove non-existing doc, TS source files. Basically only .js, .js.map and .d.ts files in the build folder need to be included,
  • remove .npmignore files since it doubles files as an blacklist.

Motivation:
@rauno56 rauno56 added bug Something isn't working up-for-grabs Good for taking. Extra help will be provided by maintainers good first issue internal never-stale labels Jan 4, 2022
@dyladan
Copy link
Member

dyladan commented Jan 4, 2022

Existence of this field seems like something that could easily be checked in CI

@rauno56
Copy link
Member Author

rauno56 commented Jan 4, 2022

Existence of this field seems like something that could easily be checked in CI

Yes, that's a good idea! Plus points for adding that for whoever will take this.

@renovate renovate bot mentioned this issue Jan 16, 2022
Closed
1 task
@renovate-bot renovate-bot mentioned this issue Jan 30, 2022
Closed
@dyladan dyladan added enhancement New feature or request and removed bug Something isn't working labels Sep 21, 2022
@dyladan dyladan added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Nov 8, 2023
@macno
Copy link
Contributor

macno commented Nov 8, 2023

ready to pick this one #contribfest

macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: cleanup files entries in package.json (open-telemetry#820)
09cf083
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: add missing files entries to package.json (open-telemetry#820)
7d92f0f
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: remove useless .npmignore (open-telemetry#820)
16c0d47
@macno macno mentioned this issue Nov 9, 2023
Merged
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: cleanup files entries in package.json (open-telemetry#820)
78ab6f3
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: add missing files entries to package.json (open-telemetry#820)
d2b2edc
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: remove useless .npmignore (open-telemetry#820)
d4a82a7
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: cleanup files entries in package.json (open-telemetry#820)
40d0643
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: add missing files entries to package.json (open-telemetry#820)
40cd221
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: remove useless .npmignore (open-telemetry#820)
6051ca3
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: cleanup files entries in package.json (open-telemetry#820)
945f809
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: add missing files entries to package.json (open-telemetry#820)
986002e
macno added a commit to macno/opentelemetry-js-contrib that referenced this issue Nov 9, 2023
@macno
chore: remove useless .npmignore (open-telemetry#820)
a709d7a
blumamir added a commit that referenced this issue Nov 13, 2023
@macno @blumamir
chore: cleanup files in package json (#1786)
9b76ffb 
* chore: typo in CONTRIBUTING.md

* chore: cleanup files entries in package.json (#820)

* chore: add missing files entries to package.json (#820)

* chore: remove useless .npmignore (#820)

---------

Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
jmcdo29 pushed a commit to jmcdo29/opentelemetry-js-contrib that referenced this issue Nov 13, 2023
@macno @blumamir @jmcdo29
chore: cleanup files in package json (open-telemetry#1786)
f7a7033 
* chore: typo in CONTRIBUTING.md

* chore: cleanup files entries in package.json (open-telemetry#820)

* chore: add missing files entries to package.json (open-telemetry#820)

* chore: remove useless .npmignore (open-telemetry#820)

---------

Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
@renovate-bot renovate-bot mentioned this issue Apr 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macno macno

Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest enhancement New feature or request good first issue internal never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: cleanup files in package json macno/opentelemetry-js-contrib
3 participants
@macno @rauno56 @dyladan