feat(propagation-utils): end pub-sub process span on promise settled

[nordfjord]

When promises are returned from a mapping function we now
end the span when that promises resolves rather than doing
so immediately.

This makes sure that the processing span wraps the entirety of the
processing

Which problem is this PR solving?

• The pubsub propagation module would end spans prematurely when promises were involved.

An example of what this looks like:

Short description of the changes

• Handle promises from mapping functions

Checklist

• Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

[blumamir]

@nordfjord thank you for the contribution :)
can you please run npm run lint:fix to revert all the linter changes? It will really help to focus on the logical changes while reviewing and make CI happy.

Also please add relevant unit tests for this change. Either in the propagation-utils package or in the aws-sdk instrumentation package which is consuming these utils. Thank you!

[nordfjord]

Thanks for taking the time to review this. I think this is ready for another review now.

[blumamir]

LGTM.
After tests are green this can be merged AFAIC

Thank you for contributing this fix

[nordfjord]

Not quite sure what was going on but I had to remove the --require @opentelemetry/contrib-test-utils part from the package.json test script so that the tests would pass.

I've verified that yarn test works locally now.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[codecov]

Codecov Report

Merging #1055 (d44c11a) into main (8873057) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   96.08%   96.20%   +0.12%     
==========================================
  Files          14       26      +12     
  Lines         893     1529     +636     
  Branches      191      325     +134     
==========================================
+ Hits          858     1471     +613     
- Misses         35       58      +23     

Impacted Files	Coverage Δ
...emetry-propagation-utils/src/pubsub-propagation.ts	88.75% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts	100.00% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts	100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts	97.29% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts	91.89% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts	93.75% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts	100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts	98.03% <0.00%> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts	97.77% <0.00%> (ø)
... and 3 more

[rauno56]

catch {} is not supported in node 8. Will merge this after #1065.