Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(instrumentation-graphql): gql supported versions #1322

Closed
wants to merge 2 commits into from
Closed

docs(instrumentation-graphql): gql supported versions #1322

wants to merge 2 commits into from

Conversation

jDzames
Copy link

@jDzames jDzames commented Dec 6, 2022

Which problem is this PR solving?

  • GQL instrumentation doc incorrectly stating supported versions are only <16.

Short description of the changes

  • README update to fix supported versions by the instrumentation (PR feat: support graphql v16 #998 should allow to also use GQL version 16, but doc still mentioned only <16).

Just doc update to fix supported versions by the instrumentation (PR #998 should allow to also use gql version 16, but doc still mentions only <16).
@jDzames jDzames requested a review from a team December 6, 2022 16:11
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 6, 2022

CLA Not Signed

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1322 (26a51a8) into main (912cde1) will decrease coverage by 4.46%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   96.08%   91.62%   -4.47%     
==========================================
  Files          14       23       +9     
  Lines         893     1611     +718     
  Branches      191      357     +166     
==========================================
+ Hits          858     1476     +618     
- Misses         35      135     +100     
Impacted Files Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.21% <0.00%> (ø)
...try-instrumentation-graphql/src/instrumentation.ts 92.85% <0.00%> (ø)
...entelemetry-instrumentation-graphql/src/symbols.ts 100.00% <0.00%> (ø)
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-graphql/src/utils.ts 93.17% <0.00%> (ø)
...nstrumentation-graphql/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...etry-instrumentation-mongodb/src/internal-types.ts 100.00% <0.00%> (ø)
...try-instrumentation-mongodb/src/instrumentation.ts 68.93% <0.00%> (ø)
...etry-instrumentation-graphql/src/internal-types.ts 100.00% <0.00%> (ø)

@blumamir
Copy link
Member

@jDzames you will need to sign the CLA so we can merge this.

@jDzames
Copy link
Author

jDzames commented Dec 15, 2022

@blumamir I see, not worth the "trouble" for me just for this one line of code (maybe later 🤷‍♂️). Someone please update it, I am closing this PR 🙂

@jDzames jDzames closed this Dec 15, 2022
@jDzames jDzames deleted the patch-1 branch December 15, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants