-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update otel core experimental to ^0.35.1 #1358
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
==========================================
- Coverage 96.08% 92.46% -3.62%
==========================================
Files 14 120 +106
Lines 893 6359 +5466
Branches 191 1274 +1083
==========================================
+ Hits 858 5880 +5022
- Misses 35 479 +444
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
seems the browser test job fails during compilation because of missing grpc types. Log output in CI is missing since a while for failures like this. Don't know why. Had no time yet to look into details why node 14 unittest job works browser doesn't work. Likely some lerna hoisting issue. |
FWIW I get a type error in our project as well due to missing grpc types when attempting to upgrade |
grpc instrumentation doesn't has @grpc/grpc-js as dependency but it seems the types are required. This type leaks/deps are a constant problem... |
Upstream is fixed - rebase this? Actually - I get a new error with 1.9.1/0.35.1:
|
http instrumentation ends server spans later which results in exporting them later. Adapt the tests to fit the new sequence.
rebased and CI is green now (besides the usual, unrelated coverage failures). @SimenB any more details why it fails in your setup? maybe you miss lib Dom in your build setup? |
Yeah, this is a node module not for the browser. 1.9.0/0.35.0 does not have the same issue |
I opened open-telemetry/opentelemetry-js#3580 |
Looks good. The release will for sure fail because of so many packages (rate limiting) but i'll manually do it after my next meeting |
Take changes from #1367 as base
Add a commit to adapt fastify tests to fit http instrumentation.
http instrumentation ends server spans later which results in exporting them later.
Adapt the tests to fit the new sequence. and additionally adapt fastify tests
Refs: open-telemetry/opentelemetry-js#3407
fyi: @legendecas