Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run browser tests with node18 #1417

Closed

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Mar 1, 2023

Check if browser tests works with node 18. They are currently fails for node14 due to "out of memory". Might be related to this issue in old node versions

@blumamir blumamir requested a review from a team March 1, 2023 17:16
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1417 (f42d782) into main (704f76f) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head f42d782 differs from pull request most recent head ee654b7. Consider uploading reports for the commit ee654b7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
+ Coverage   96.06%   96.13%   +0.07%     
==========================================
  Files          14       14              
  Lines         914      906       -8     
  Branches      199      197       -2     
==========================================
- Hits          878      871       -7     
+ Misses         36       35       -1     

see 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even with the original reason gone, we can still go ahead with PR - updating it to run on node 18 won't hurt. WDYT @blumamir ? 🙂

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jun 5, 2023
@github-actions github-actions bot removed the stale label Jun 12, 2023
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@blumamir
Copy link
Member Author

Closing so we can address this after code coverage stabilizes.
Opened an issue to track: #1634

@blumamir blumamir closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants