-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run browser tests with node18 #1417
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
+ Coverage 96.06% 96.13% +0.07%
==========================================
Files 14 14
Lines 914 906 -8
Branches 199 197 -2
==========================================
- Hits 878 871 -7
+ Misses 36 35 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think even with the original reason gone, we can still go ahead with PR - updating it to run on node 18 won't hurt. WDYT @blumamir ? 🙂
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Closing so we can address this after code coverage stabilizes. |
Check if browser tests works with node 18. They are currently fails for node14 due to "out of memory". Might be related to this issue in old node versions