-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update otel core experimental to ^0.41.0 #1566
fix(deps): update otel core experimental to ^0.41.0 #1566
Conversation
Possibly related: #1434 was a recent-ish fix for renovate for updating deps to ^0.40.0. The renovate schedule is: The 0.41 release (open-telemetry/opentelemetry-js#3963) was merged last Thursday:
and
I have no experience with Renovate, but I would have expected it to attempt to update on Friday morning. (I'm here because of the linked require-in-the-middle issue. :) |
It should have run on friday morning, but the dependency dashbaord tells me that the PR is awaiting schedule. I think for these dependencies it may be worth to have that run daily - could'nt see any errors in the renovate job log, but they only go back one day, so something may have gone wrong somewhere - all it takes is some timeout while the bot is running, then it takes a week for it to open the PR again. 🤔 I forced the creation of the PR now to ensure it's working. I'll also look into bumping the schedule to daily, we typically don't always release on the same day of the week so it would make sense to react more quickly to core updates. 🙂 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 14 14
Lines 914 914
Branches 199 199
=======================================
Hits 878 878
Misses 36 36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, I looks like one was missing but I took the liberty to push a commit that also adds the last one 🙂
In the meantime I forced a renovate run, and it seems it's working again. I'll open a PR regardless to bump the schedule for otel core updates to run daily.
Which problem is this PR solving?
I'm using the latest version of the experimental
@opentelemetry/*
packages in my project. However, because the instrumentations in this repo don't use that latest version, I end up with many copies of@opentelemetry/instrumentation
installed. This, in turn, results in one instance ofrequire-in-the-middle
per instrumentation, which severely slows down the loading time of my application.Short description of the changes
I patterned this diff off of #1527. I used find/replace to actually bump all the versions.
It seems like renovate should be doing these bumps automatically, but I don't see any recent PRs from it that would have performed these updates.