Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use opentelemetrybot to sync package-lock.json on release PRs #1817

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 21, 2023

Which problem is this PR solving?

Short description of the changes

  • uses opentelemetrybot credentials to create release PRs via release please
  • adds a commit as opentelemetrybot, which syncs the package-lock.json (@opentelemetrybot has signed the CLA)

@pichlermarc pichlermarc requested a review from a team November 21, 2023 09:36
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #1817 (6d90d19) into main (434cab2) will not change coverage.
The diff coverage is n/a.

❗ Current head 6d90d19 differs from pull request most recent head d07fa9c. Consider uploading reports for the commit d07fa9c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1817   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         143      143           
  Lines        7303     7303           
  Branches     1461     1461           
=======================================
  Hits         6677     6677           
  Misses        626      626           

git push

# get main again
- name: Checkout Repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: if you want to speed up the process you could avoid checking out again by cleaning up the workspace just after pushing you could add the following commands

git clean -xdf
npm ci
npm run compile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes we'd also have to check out main though as we might be on another branch at this point in the workflow.

It's also relatively quick (about 2s) compared to the rest of the workflow so I'd opt to keep it as-is (here's an example run https://github.com/pichlermarc-sample-organization/test-release-please/actions/runs/6941681633/job/18883019651). 🙂

@pichlermarc pichlermarc merged commit fce33b6 into open-telemetry:main Nov 22, 2023
12 checks passed
@pichlermarc pichlermarc deleted the fix/release-please branch November 22, 2023 08:48
@pichlermarc pichlermarc mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants