-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): use opentelemetrybot to sync package-lock.json on release PRs #1817
fix(ci): use opentelemetrybot to sync package-lock.json on release PRs #1817
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1817 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 143 143
Lines 7303 7303
Branches 1461 1461
=======================================
Hits 6677 6677
Misses 626 626 |
git push | ||
|
||
# get main again | ||
- name: Checkout Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: if you want to speed up the process you could avoid checking out again by cleaning up the workspace just after pushing you could add the following commands
git clean -xdf
npm ci
npm run compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes we'd also have to check out main though as we might be on another branch at this point in the workflow.
It's also relatively quick (about 2s) compared to the rest of the workflow so I'd opt to keep it as-is (here's an example run https://github.com/pichlermarc-sample-organization/test-release-please/actions/runs/6941681633/job/18883019651). 🙂
Which problem is this PR solving?
Short description of the changes