test(instrumentation-aws-sdk): skip failing tests of @aws-sdk/client-sqs ReceiveMessage context handling #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and context' test
…trumentation that is failing: passing span context to the receiveMessage promise handler
This was referenced Dec 5, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 144
Lines 7406 7406
Branches 1483 1483
=======================================
Hits 6773 6773
Misses 633 633 |
…ient-sqs versions using the AWS JSON 1.0 protocol (open-telemetry#1844) Versions 3.446.0 and later switched to a new JSON protocol. https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08 Refs: open-telemetry#1838 (comment)
…ONS_EXTENSION_VERSION is defined (open-telemetry#1846)
…skipped; doc the reason for skipping this test
pichlermarc
approved these changes
Dec 11, 2023
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Yep, splitting it like this is better. Thanks @trentm 🙂
Contributor
Author
|
Woot. aws-sdk tav tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1477
Refs: #707
Tests of
@aws-sdk/client-sqsinstrumentation are failing for versions >=3.316.0. The issue (#1477 (comment)) may take a while to resolve. This disables the subset of tests that are failing.This is an alternative to @pichlermarc's #1711 that reduces the set of tests being skipped to just the problematic ones.