Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-generic-pool): update span name typo #2405

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

Zen-cronic
Copy link
Contributor

Which problem is this PR solving?

  • The current span name emitted from @opentelemetry/instrumentation-generic-pool is generic-pool.aquire, but it should be generic-pool.acquire instead. For instance, see this PR.

Short description of the changes

  • Span name changed to generic-pool.acquire

Should be 'generic-pool.acquire' instead of 'generic-pool.aquire'

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic Zen-cronic requested a review from a team August 26, 2024 22:09
@github-actions github-actions bot added pkg:instrumentation-generic-pool pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Aug 26, 2024
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (dfb2dff) to head (32a1b63).
Report is 221 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2405      +/-   ##
==========================================
- Coverage   90.97%   90.52%   -0.45%     
==========================================
  Files         146      157      +11     
  Lines        7492     7622     +130     
  Branches     1502     1571      +69     
==========================================
+ Hits         6816     6900      +84     
- Misses        676      722      +46     
Files Coverage Δ
...nstrumentation-generic-pool/src/instrumentation.ts 40.54% <ø> (+0.54%) ⬆️

... and 74 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 2105609 into open-telemetry:main Aug 27, 2024
9 checks passed
@dyladan dyladan mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:instrumentation-generic-pool pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants