Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-pg): add error type to db duration metric #2476

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add error type to db duration operation metric. It uses the error codes from postgres, so we can limit cardinality and they're well known error codes.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (9b43ccb) to head (6926399).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2476   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         159      159           
  Lines        7851     7853    +2     
  Branches     1621     1622    +1     
=======================================
+ Hits         7133     7135    +2     
  Misses        718      718           
Files with missing lines Coverage Δ
...elemetry-instrumentation-pg/src/instrumentation.ts 89.72% <ø> (ø)
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.65% <100.00%> (+0.03%) ⬆️

@maryliag maryliag changed the title add error type to db duration metric feat(instrumentation-pg): add error type to db duration metric Oct 10, 2024
@pichlermarc pichlermarc merged commit 9564380 into open-telemetry:main Oct 25, 2024
20 checks passed
@dyladan dyladan mentioned this pull request Oct 25, 2024
@maryliag maryliag deleted the db-error branch October 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants