Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(multiple): update readme for semantic convention #2529

Merged
merged 1 commit into from
Nov 18, 2024
Merged

docs(multiple): update readme for semantic convention #2529

merged 1 commit into from
Nov 18, 2024

Conversation

raymonslickdeals
Copy link
Contributor

@raymonslickdeals raymonslickdeals commented Nov 15, 2024 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • updates readme to include section for semantic convention for those readme that do not have semantic convention usage.
  • Following readme where updated:
  1. plugins/node/instrumentation-dataloader/README.md
  2. plugins/node/instrumentation-fs/README.md
  3. plugins/web/opentelemetry-instrumentation-long-task/README.md
  4. plugins/web/opentelemetry-instrumentation-user-interaction/README.md

@raymonslickdeals raymonslickdeals requested a review from a team as a code owner November 15, 2024 23:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 15, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: raymonslickdeals / name: Raymon Leon (b1f1536)

@JamieDanielson
Copy link
Member

/easycla

JamieDanielson
JamieDanielson approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (5eb61d8) to head (b1f1536).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741

@JamieDanielson JamieDanielson added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@raymonslickdeals
Copy link
Contributor Author

Thanks for updating this!

It looks like this package does not have a component owner / maintainer thus blocking this PR.

@pichlermarc
Copy link
Member

@raymonslickdeals all good, we can still merge it 🙂

@pichlermarc pichlermarc merged commit bc647fc into open-telemetry:main Nov 18, 2024
23 checks passed
drewcorlin1 pushed a commit to drewcorlin1/opentelemetry-js-contrib that referenced this pull request Dec 3, 2024
@raymonslickdeals @drewcorlin1
docs(multiple): update readme for semantic convention (open-telemetry…
1d2a277 
…#2529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@obecny obecny

Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest pkg:instrumentation-dataloader pkg:instrumentation-fs pkg:instrumentation-long-task pkg:instrumentation-user-interaction pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raymonslickdeals @JamieDanielson @pichlermarc @obecny