feat(detectors): mark as side effect free #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:resource-detector-instana
pkg:resource-detector-container
pkg:resource-detector-azure
pkg-status:unmaintained
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2663 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 169 169
Lines 8061 8061
Branches 1646 1646
=======================================
Hits 7319 7319
Misses 742 742 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In my previous PR, I have forgotten to mark resource detector modules as side effect free. So, during my internal tests with custom built resource detector packages, I have noticed that they are not tree-shaked by webpack even though they are not referenced.
Short description of the changes
Add
sideEffectsproperty asfalseto thepackage.jsonfiles of all the resource detector modules.