-
Notifications
You must be signed in to change notification settings - Fork 616
refactor: hoist all devDeps to root #3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: hoist all devDeps to root #3032
Conversation
99cc06d to
324495b
Compare
469663e to
9cb3aef
Compare
... because we are seeing hangs in `npm ci` on #3032.
6fce51c to
6e7f06f
Compare
|
@trentm I repaired the lockfile and this is finally 🟢. Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple smaller Qs left.
79da445 to
57d2922
Compare
Unhelpful npm rantI want to try to care about reviewing package-lock changes, but ... npm, I don't even. This latest update:
- "resolved": "https://registry.npmjs.org/uuid/-/uuid-9.0.1.tgz",
- "integrity": "sha512-b+1eJOlsR9K8HJpow9Ok3fiWOWSIcIzXodvv0rQjVoOVNpWMpxf1wZNpt4y9h10odCNrqnYp1OBzRktckBe3sA==",So basically those fields are just useless noise from npm in lock files. What a waste. The package-lock.json tooling design is ...poor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the "package-lock has lost all the platform-specific optionalDependencies except the one platform" problem again, described at https://cloud-native.slack.com/archives/C08T7MZTV8W/p1761781178575799?thread_ts=1761762353.429559&cid=C08T7MZTV8W
You'll need to manually re-add them, or do some voodoo process under a full moon something like the following to correctly re-gen the lock file:
rm package-lock.json
rm -rf node_modules
npm i
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unforunately in the latest update a number of deps in package-lock.json were incorrectly marked with "peer": true due to a bug in npm.
For example, here is a subset of them (this is partial output of running https://github.com/trentm/npm-tools/blob/main/bin/package-lock-diff):
- node_modules/react: 17.0.2 (dev)
+ node_modules/react: 17.0.2 (dev, peer)
- node_modules/reflect-metadata: 0.2.2 (dev)
+ node_modules/reflect-metadata: 0.2.2 (dev, peer)
- node_modules/rollup: 4.52.5 (dev)
+ node_modules/rollup: 4.52.5 (dev, peer)
- node_modules/rxjs: 7.8.2 (dev)
+ node_modules/rxjs: 7.8.2 (dev, peer)
- node_modules/schema-utils/node_modules/ajv: 8.17.1 (dev)
+ node_modules/schema-utils/node_modules/ajv: 8.17.1 (dev, peer)
- node_modules/ts-node: 10.9.2 (dev)
+ node_modules/ts-node: 10.9.2 (dev, peer)
- node_modules/typescript: 5.0.4 (dev)
+ node_modules/typescript: 5.0.4 (dev, peer)
- node_modules/webpack: 5.102.0 (dev)
+ node_modules/webpack: 5.102.0 (dev, peer)
- node_modules/webpack-cli: 6.0.1 (dev)
+ node_modules/webpack-cli: 6.0.1 (dev, peer)My guess is that you regenerated the package-lock file using npm@11.6.1 or npm@11.6.2 -- both of which are broken. The expectation is that this will be fixed by npm/cli#8645 which should be in the npm 11.6.3 release.
For now, please regenerate the lock file using npm 11.6.0 or earlier.
48f82c1 to
bec6114
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unforunately in the latest update a number of deps in package-lock.json were incorrectly marked with "peer": true due to a bug in npm.
For example, here is a subset of them (this is partial output of running https://github.com/trentm/npm-tools/blob/main/bin/package-lock-diff):
- node_modules/react: 17.0.2 (dev)
+ node_modules/react: 17.0.2 (dev, peer)
- node_modules/reflect-metadata: 0.2.2 (dev)
+ node_modules/reflect-metadata: 0.2.2 (dev, peer)
- node_modules/rollup: 4.52.5 (dev)
+ node_modules/rollup: 4.52.5 (dev, peer)
- node_modules/rxjs: 7.8.2 (dev)
+ node_modules/rxjs: 7.8.2 (dev, peer)
- node_modules/schema-utils/node_modules/ajv: 8.17.1 (dev)
+ node_modules/schema-utils/node_modules/ajv: 8.17.1 (dev, peer)
- node_modules/ts-node: 10.9.2 (dev)
+ node_modules/ts-node: 10.9.2 (dev, peer)
- node_modules/typescript: 5.0.4 (dev)
+ node_modules/typescript: 5.0.4 (dev, peer)
- node_modules/webpack: 5.102.0 (dev)
+ node_modules/webpack: 5.102.0 (dev, peer)
- node_modules/webpack-cli: 6.0.1 (dev)
+ node_modules/webpack-cli: 6.0.1 (dev, peer)My guess is that you regenerated the package-lock file using npm@11.6.1 or npm@11.6.2 -- both of which are broken. The expectation is that this will be fixed by npm/cli#8645 which should be in the npm 11.6.3 release.
For now, please regenerate the lock file using npm 11.6.0 or earlier.
bec6114 to
41c5ef5
Compare
What this does
Hoists all build devDependencies to the root package.json.
Key changes
Test fixes
Dependencies
Configuration
Package-specific changes
@opentelemetry/instrumentation-socket.io
import * as expecttoimport expect(expect v29 uses default export)@opentelemetry/instrumentation-dns
@opentelemetry/instrumentation-aws-sdk
Browser packages (propagator-aws-xray, propagator-instana, instrumentation-user-interaction, instrumentation-long-task)