ci(release-please): combine npm publish workflow jobs to avoid file perm issues from zip files used by upload-artifact #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erm issues from zip files used by upload-artifact With the previous separate of jobs, the built files to publish were shared across jobs with upload/download-artifact. This uses zip files, which cannot handle the execute bit on files. This resulted in lerna publish spuriously erroring out thinking there were uncommited changes to the handful of files in scripts/ that intentional have the execute file perm set. Refs: open-telemetry#3107 (comment)
pichlermarc
approved these changes
Sep 25, 2025
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Sep 25, 2025
trentm
added a commit
that referenced
this pull request
Sep 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous separate of jobs, the built files to publish were shared
across jobs with upload/download-artifact. This uses zip files, which cannot
handle the execute bit on files. This resulted in lerna publish spuriously
erroring out thinking there were uncommited changes to the handful of
files in scripts/ that intentional have the execute file perm set.
Refs: #3107 (comment)