Skip to content

chore(ci): limit installs to 10 minutes #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

chore(ci): limit installs to 10 minutes #3197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/test-all-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
node-version: 18
- name: Install
run: npm ci --ignore-scripts
timeout-minutes: 10
- name: Build
run: npm run compile
- name: Upload Build Artifacts
Expand All @@ -57,14 +58,14 @@ jobs:
mongo:
image: mongo
ports:
- 27017:27017
- 27017:27017
mssql:
image: mcr.microsoft.com/mssql/server:2022-latest
env:
MSSQL_SA_PASSWORD: mssql_passw0rd
ACCEPT_EULA: Y
ports:
- 1433:1433
- 1433:1433
options: >-
--health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P $MSSQL_SA_PASSWORD -C -Q 'select 1' -b -o /dev/null"
--health-interval 1s
Expand All @@ -79,7 +80,7 @@ jobs:
MYSQL_DATABASE: otel_mysql_database
MYSQL_ROOT_PASSWORD: rootpw
ports:
- 3306:3306
- 3306:3306
options: >-
--health-cmd="mysqladmin ping"
--health-interval 10s
Expand All @@ -105,7 +106,7 @@ jobs:
POSTGRES_DB: otel_pg_database
POSTGRES_PASSWORD: postgres
ports:
- 5432:5432
- 5432:5432
options: >-
--health-cmd pg_isready
--health-interval 10s
Expand All @@ -114,14 +115,14 @@ jobs:
rabbitmq:
image: rabbitmq:3
ports:
- 22221:5672
- 22221:5672
env:
RABBITMQ_DEFAULT_USER: username
RABBITMQ_DEFAULT_PASS: password
redis:
image: redis
ports:
- 6379:6379
- 6379:6379
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
Expand Down Expand Up @@ -171,6 +172,7 @@ jobs:
# Post install scripts are required for some deps for successful test
# runs: sqlite3, better-sqlite3, and possibly esbuild.
run: npm ci
timeout-minutes: 10
- name: Download Build Artifacts
uses: actions/download-artifact@v5
with:
Expand Down
21 changes: 12 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
node-version: 18
- name: Install
run: npm ci --ignore-scripts
timeout-minutes: 10
# Note: when pushing to main we want to test only what changed in
# last commit. Otherwise we want to test all changes from origin/main.
# So we set the right values for base and head commits depending
Expand Down Expand Up @@ -71,18 +72,18 @@ jobs:
memcached:
image: memcached:1.6.39-alpine
ports:
- 11211:11211
- 11211:11211
mongo:
image: mongo
ports:
- 27017:27017
- 27017:27017
mssql:
image: mcr.microsoft.com/mssql/server:2022-latest
env:
MSSQL_SA_PASSWORD: mssql_passw0rd
ACCEPT_EULA: Y
ports:
- 1433:1433
- 1433:1433
options: >-
--health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P $MSSQL_SA_PASSWORD -C -Q 'select 1' -b -o /dev/null"
--health-interval 1s
Expand All @@ -97,7 +98,7 @@ jobs:
MYSQL_DATABASE: otel_mysql_database
MYSQL_ROOT_PASSWORD: rootpw
ports:
- 3306:3306
- 3306:3306
options: >-
--health-cmd="mysqladmin ping"
--health-interval 10s
Expand All @@ -123,7 +124,7 @@ jobs:
POSTGRES_DB: otel_pg_database
POSTGRES_PASSWORD: postgres
ports:
- 5432:5432
- 5432:5432
options: >-
--health-cmd pg_isready
--health-interval 10s
Expand All @@ -132,7 +133,7 @@ jobs:
redis:
image: redis
ports:
- 6379:6379
- 6379:6379
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
Expand All @@ -141,11 +142,11 @@ jobs:
cassandra:
image: cassandra:3
ports:
- 9042:9042
- 9042:9042
rabbitmq:
image: rabbitmq:3
ports:
- 22221:5672
- 22221:5672
Copy link
Contributor

@trentm trentm Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is this from some local yaml lint tool you have?

Copy link
Contributor Author

@overbalance overbalance Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, Prettier runs in Zed on save, by default.

env:
RABBITMQ_DEFAULT_USER: username
RABBITMQ_DEFAULT_PASS: password
Expand Down Expand Up @@ -198,6 +199,7 @@ jobs:
node-version: ${{ matrix.node }}
- name: Install
run: npm ci
timeout-minutes: 10
- name: Download Build Artifacts
uses: actions/download-artifact@v5
with:
Expand Down Expand Up @@ -242,6 +244,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
- run: npm ci
timeout-minutes: 10
- name: Download Build Artifacts
uses: actions/download-artifact@v5
with:
Expand Down Expand Up @@ -286,6 +289,7 @@ jobs:
node-version: 18
- name: Install
run: npm ci --ignore-scripts
timeout-minutes: 10
# Note: Keep this in sync with the node versions from `test-all-versions` job.
- name: Download Test Artifacts (18)
uses: actions/download-artifact@v5
Expand All @@ -312,4 +316,3 @@ jobs:
env:
COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
PR_BRANCH_NAME: ${{ github.event.pull_request.head.label }}