Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OpenTracingPropagator -> OTTracePropagator rename #329

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

mwear
Copy link
Member

@mwear mwear commented Jan 30, 2021

Which problem is this PR solving?

This PR renames the OpenTracingPropagator to OTTracePropagator as per this spec issue: open-telemetry/opentelemetry-specification#1391, specifically this comment: open-telemetry/opentelemetry-specification#1391 (comment). As discussed in the issue, there was not a single context propagation format specified in OpenTracing, but there were several that gained some adoption. The OT trace format was adopted by Lightstep and was also used by the "basic tracer" implementations in OpenTracing.

Short description of the changes

  • Renames the OpenTracingPropagator to OTTracePropagator
  • Renames the package from opentelemetry-propagator-opentracing to opentelemetry-propagator-ot-trace

@mwear mwear requested a review from a team January 30, 2021 00:21
@mwear mwear changed the title refacor: OpenTracingPropagator -> OTTracePropagator rename refactor: OpenTracingPropagator -> OTTracePropagator rename Jan 30, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #329 (3987085) into main (d59bd00) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         119      119           
  Lines        6273     6273           
  Branches      609      609           
=======================================
  Hits         5990     5990           
  Misses        283      283           
Impacted Files Coverage Δ
...ors/opentelemetry-propagator-ot-trace/.eslintrc.js 0.00% <ø> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <ø> (ø)
...metry-propagator-ot-trace/src/OTTracePropagator.ts 95.83% <100.00%> (ø)
...propagator-ot-trace/test/OTTracePropagator.test.ts 100.00% <100.00%> (ø)

@Flarna Flarna mentioned this pull request Jan 30, 2021
@vmarchaud vmarchaud merged commit eb7ebd1 into open-telemetry:main Feb 1, 2021
@obecny obecny added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants