-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 0.15.0 release proposal #401
chore: 0.15.0 release proposal #401
Conversation
@@ -42,8 +42,8 @@ | |||
}, | |||
"devDependencies": { | |||
"@opentelemetry/context-async-hooks": "0.18.0", | |||
"@opentelemetry/test-utils": "^0.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@opentelemetry/test-utils": "^0.15.0", | |
"@opentelemetry/test-utils": "0.15.0", |
At least I think this is what renovate bot usually requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think lerna does this, then the renovate bot undoes it. Maybe lerna can be configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't care that much, just noticed during scanning the files. Feel free to let the bots do the work.
@@ -45,8 +45,8 @@ | |||
"devDependencies": { | |||
"@opentelemetry/context-async-hooks": "0.18.0", | |||
"@opentelemetry/node": "0.18.0", | |||
"@opentelemetry/test-utils": "^0.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -49,7 +49,7 @@ | |||
"devDependencies": { | |||
"@opentelemetry/context-async-hooks": "0.18.0", | |||
"@opentelemetry/node": "0.18.0", | |||
"@opentelemetry/test-utils": "^0.14.0", | |||
"@opentelemetry/test-utils": "^0.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -44,7 +44,7 @@ | |||
"@opentelemetry/context-async-hooks": "0.18.0", | |||
"@opentelemetry/node": "0.18.0", | |||
"@opentelemetry/semantic-conventions": "0.18.0", | |||
"@opentelemetry/test-utils": "^0.14.0", | |||
"@opentelemetry/test-utils": "^0.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once again
Regarding the compile problem you have here. I think it's caused by the transitive dependency to Maybe updating all dependencies to latests solves the problem also. |
Thanks. There is also a problem with the transitive dependencies hinted in open-telemetry/opentelemetry-js#2065. The build fails because one of our dependencies (web) depends on another (tracing) with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will publish propagator-jaeger@0.15.0
, even though it was already published @0.18.2
. If we resolve the Hapi issue I can rebase #351 and we'll be good to merge it before publishing this release.
Your suggested fix doesn't work for me at least locally. Skipping lib checks in the tsconfig does, but that feels somehow wrong to me. |
We could only skip it for Hapi, sadly it sometimes happen and generally requires upstream dependencies to fix their types which can take some time. In our case that shouldn't impact too much i believe |
That's strange as I tried it locally and it worked for me. |
Can you send me the exact package.json? Or open a PR? |
Created #407 - let the CI decide |
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 95.83% 94.43% -1.41%
==========================================
Files 1 11 +10
Lines 24 431 +407
Branches 4 48 +44
==========================================
+ Hits 23 407 +384
- Misses 1 24 +23
|
Closing in favor of the bot version #409 |
🚀 Enhancement
opentelemetry-host-metrics
🏠 Internal
📝 Documentation
opentelemetry-host-metrics
Committers: 7