Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prefer use of global TracerProvider/MeterProvider #450

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Apr 26, 2021

Remove setting of TracerProvider in samples where it is actually not needed as the global TracerProvider should be preferred on default.

I found it also inconsistent to set a TracerProvider but no MeterProvider.

Besides that I fixed some warnings in md files and net test on windows.

Refs.: open-telemetry/opentelemetry-js#2127

Remove setting of TracerProvider in samples where it is actually not needed as the global TracerProvider should be preferred on default.

I found it also inconsistent to set a TracerProvider but no MeterProvider.
@Flarna Flarna requested a review from a team April 26, 2021 08:33
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #450 (c1ec89f) into main (862ab4e) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c1ec89f differs from pull request most recent head a36fffe. Consider uploading reports for the commit a36fffe to get more accurate results

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   95.22%   95.21%   -0.02%     
==========================================
  Files         133      133              
  Lines        8176     8178       +2     
  Branches      802      804       +2     
==========================================
+ Hits         7786     7787       +1     
- Misses        390      391       +1     
Impacted Files Coverage Δ
...de/opentelemetry-instrumentation-net/test/utils.ts 96.15% <0.00%> (-3.85%) ⬇️

@Flarna Flarna added the documentation Improvements or additions to documentation label Apr 26, 2021
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny merged commit 041508f into open-telemetry:main Apr 26, 2021
@Flarna Flarna deleted the prefer-global-providers branch April 26, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants