Skip to content

Commit 16a3316

Browse files
authored
Use new gRPC default port (#1725)
1 parent c1d4264 commit 16a3316

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

examples/collector-exporter-node/docker/docker-compose.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ services:
99
- ./collector-config.yaml:/conf/collector-config.yaml
1010
ports:
1111
- "9464:9464"
12-
- "55680:55680"
12+
- "4317:4317"
1313
- "55681:55681"
1414
depends_on:
1515
- zipkin-all-in-one

packages/opentelemetry-exporter-collector-grpc/README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[![devDependencies][devDependencies-image]][devDependencies-url]
77
[![Apache License][license-image]][license-image]
88

9-
This module provides exporter for web and node to be used with [opentelemetry-collector][opentelemetry-collector-url] - last tested with version **0.6.0**.
9+
This module provides exporter for web and node to be used with [opentelemetry-collector][opentelemetry-collector-url] - last tested with version **0.16.0**.
1010

1111
## Installation
1212

@@ -24,7 +24,7 @@ const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector-g
2424

2525
const collectorOptions = {
2626
serviceName: 'basic-service',
27-
url: '<opentelemetry-collector-url>' // url is optional and can be omitted - default is localhost:55680
27+
url: '<opentelemetry-collector-url>' // url is optional and can be omitted - default is localhost:4317
2828
};
2929

3030
const provider = new BasicTracerProvider();
@@ -45,7 +45,7 @@ const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector-g
4545

4646
const collectorOptions = {
4747
serviceName: 'basic-service',
48-
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is localhost:55680
48+
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is localhost:4317
4949
credentials: grpc.credentials.createSsl(
5050
fs.readFileSync('./ca.crt'),
5151
fs.readFileSync('./client.key'),
@@ -74,7 +74,7 @@ metadata.set('k', 'v');
7474

7575
const collectorOptions = {
7676
serviceName: 'basic-service',
77-
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is localhost:55680
77+
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is localhost:4317
7878
metadata, // // an optional grpc.Metadata object to be sent with each request
7979
};
8080

packages/opentelemetry-exporter-collector-grpc/src/CollectorMetricExporter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { CollectorExporterConfigNode, ServiceClientType } from './types';
2323
import { CollectorExporterNodeBase } from './CollectorExporterNodeBase';
2424

2525
const DEFAULT_SERVICE_NAME = 'collector-metric-exporter';
26-
const DEFAULT_COLLECTOR_URL = 'localhost:55680';
26+
const DEFAULT_COLLECTOR_URL = 'localhost:4317';
2727

2828
/**
2929
* Collector Metric Exporter for Node

packages/opentelemetry-exporter-collector-grpc/src/CollectorTraceExporter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
import { CollectorExporterConfigNode, ServiceClientType } from './types';
2424

2525
const DEFAULT_SERVICE_NAME = 'collector-trace-exporter';
26-
const DEFAULT_COLLECTOR_URL = 'localhost:55680';
26+
const DEFAULT_COLLECTOR_URL = 'localhost:4317';
2727

2828
/**
2929
* Collector Trace Exporter for Node

packages/opentelemetry-exporter-collector-grpc/test/CollectorMetricExporter.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ describe('CollectorMetricExporter - node (getDefaultUrl)', () => {
229229
it('should default to localhost', done => {
230230
const collectorExporter = new CollectorMetricExporter({});
231231
setTimeout(() => {
232-
assert.strictEqual(collectorExporter['url'], 'localhost:55680');
232+
assert.strictEqual(collectorExporter['url'], 'localhost:4317');
233233
done();
234234
});
235235
});

packages/opentelemetry-exporter-collector-grpc/test/CollectorTraceExporter.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ describe('CollectorTraceExporter - node (getDefaultUrl)', () => {
194194
it('should default to localhost', done => {
195195
const collectorExporter = new CollectorTraceExporter({});
196196
setTimeout(() => {
197-
assert.strictEqual(collectorExporter['url'], 'localhost:55680');
197+
assert.strictEqual(collectorExporter['url'], 'localhost:4317');
198198
done();
199199
});
200200
});

packages/opentelemetry-exporter-collector-proto/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[![devDependencies][devDependencies-image]][devDependencies-url]
77
[![Apache License][license-image]][license-image]
88

9-
This module provides exporter for node to be used with [opentelemetry-collector][opentelemetry-collector-url] - last tested with version **0.6.0**.
9+
This module provides exporter for node to be used with [opentelemetry-collector][opentelemetry-collector-url] - last tested with version **0.16.0**.
1010

1111
## Installation
1212

0 commit comments

Comments
 (0)